Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Tizen] Fix Frame cliping issue #12921

Merged
merged 2 commits into from
Nov 23, 2020
Merged

[Tizen] Fix Frame cliping issue #12921

merged 2 commits into from
Nov 23, 2020

Conversation

myroot
Copy link
Contributor

@myroot myroot commented Nov 20, 2020

Description of Change

  • This PR solved the cliping issue of Frame when Frame was scrolled

Issues Resolved

  • fixes #

API Changes

None

Platforms Affected

  • Tizen

Behavioral/Visual Changes

None

Before/After Screenshots

Before After
frame-cliper-before frame-cliper-after

Testing Procedure

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

rookiejava
rookiejava approved these changes Nov 23, 2020
View reviewed changes
Copy link
Collaborator

@rookiejava rookiejava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rookiejava
rookiejava reviewed Nov 23, 2020
View reviewed changes
Copy link
Collaborator

@rookiejava rookiejava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please modify CanvasViewRenderer as well. And, it;s not a big deal, but seems to corrent typo (cliper -> Clipper). 😉

@rookiejava rookiejava self-requested a review November 23, 2020 06:13
@rmarinho rmarinho merged commit 1c817d8 into xamarin:5.0.0 Nov 23, 2020
@samhouts samhouts added this to the 5.0.0 milestone Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rookiejava rookiejava rookiejava approved these changes

Assignees
No one assigned
Labels
a/shapes p/Tizen
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@myroot @rookiejava @rmarinho @jsuarezruiz @samhouts @JoonghyunCho