Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Enable Shell tests on UWP and fix a few bugs #12938

Merged
merged 2 commits into from
Nov 26, 2020
Merged

Enable Shell tests on UWP and fix a few bugs #12938

merged 2 commits into from
Nov 26, 2020

Conversation

PureWeen
Copy link
Contributor

Description of Change

  • Removed shell filter from UWP UI tests
  • When the FlyoutBehavior is set to disabled make sure to still show backbutton
  • When switching shell sections synchronize frame to current navigation stack
  • Fix Top Tabs so they hide and show correctly as top tabs are removed and shown

Platforms Affected

  • UWP

Testing Procedure

  • UWP tests pass

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@PureWeen PureWeen added this to the 5.0.0 milestone Nov 22, 2020
@PureWeen PureWeen added this to To do in vNext+1 (5.0.0) via automation Nov 22, 2020
@PureWeen PureWeen added p/UWP a/shell 🐚 blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. labels Nov 22, 2020
@PureWeen PureWeen moved this from To do to In Review in vNext+1 (5.0.0) Nov 24, 2020
@rmarinho rmarinho self-requested a review November 24, 2020 19:04
@rmarinho rmarinho merged commit 3c34d86 into 5.0.0 Nov 26, 2020
vNext+1 (5.0.0) automation moved this from In Review to Done Nov 26, 2020
@rmarinho rmarinho deleted the uwp_shell_tweaks branch November 26, 2020 17:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rmarinho rmarinho rmarinho approved these changes

@jsuarezruiz jsuarezruiz jsuarezruiz approved these changes

Assignees
No one assigned
Labels
a/shell 🐚 blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. p/UWP
Projects
No open projects
vNext+1 (5.0.0)
Done
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PureWeen @rmarinho @jsuarezruiz