This repository has been archived by the owner on May 1, 2024. It is now read-only.
[macOS] Hang App scaling a View to zero #13005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samhouts
added
p/iOS 🍎
good first issue
i/high
mattleibow
suggested changes
Dec 10, 2020
There was a problem hiding this comment.
Scaling to negative values on both X and Y cause the last axis to actually snap to 0.
I think this is because we only update the fields when at least one of the axis are positive. However, when both are negative, the logic fails.
Also, since the variables in the scope have the same name, it might cause a bit of confusion.
|
@mattleibow Thanks for the feedback!. I have made changes to cover all cases. |
mattleibow
approved these changes
Feb 16, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Hang or crash macOS App scaling a View to zero.
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Before
Hang in the first case and getting a crash in the second case setting the Scale to zero.
Ater
Testing Procedure
PR Checklist