This repository has been archived by the owner on May 1, 2024. It is now read-only.
[iOS] Fix NRE in PageRenderer #13013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @jsuarezruiz is it possible to add a UITest? |
|
Not sure exactly how to reproduce it. I asked @VladislavAntonyuk for a repro sample. If we can have a way to reproduce it, for sure, will include a UITest. |
|
@jsuarezruiz I was not able to reproduce the issue in the latest nightly build, but anyway your fix should prevent any future related problems |
samhouts
added
i/high
rmarinho
approved these changes
Dec 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix NRE in PageRenderer
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
PR Checklist