This repository has been archived by the owner on May 1, 2024. It is now read-only.
Convert ShellContent transitions to use animators and be smarter about selecting visible content #13046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
added
the
blocker
pictos
approved these changes
Dec 3, 2020
PureWeen
commented
Dec 4, 2020
|
|
||
| currentRenderer.NativeView.Frame = new CGRect(-motionDirection * View.Bounds.Width, 0, View.Bounds.Width, View.Bounds.Height); | ||
| UIViewPropertyAnimator CreateContentAnimator( |
There was a problem hiding this comment.
@GiampaoloGabba I'm thinking after this PR is merged we can make this or something close to this virtual for some added animation customizations!!
There was a problem hiding this comment.
nice! i need to explore the other platforms renderers for the equivalent animation.
For now i jsut played with the NavigationPage (and shell equivalent) animatins, i skipped tabbed because we dont have animations in the TabbedPage for iOS.
For MAUI i will focus more on shell: is more flexibile. As today i dont use much shell because is not well integrated with libraries like PRISM, but from my understating this will change for MAUI, so maybe i will go "full-in" with shell animations
pictos
pushed a commit
to pictos/Xamarin.Forms
that referenced
this pull request
Dec 30, 2020
…t selecting visible content (xamarin#13046) fixes xamarin#12642 * Convert to Property Animators * - uitests * Update ShellSectionRootRenderer.cs * - fix nre
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
On iOS when transitioning really quickly the animations would start to overlap which would cause all the UIViews to become removed once the animations resolved. I converted over to using a UIViewPropertyAnimator so that I can cancel the animation if the user clicks quickly enough that it has resolved.
Once the animation concludes the code now just figures out who should be visible instead of using messy closures from whoever started the animation.
Issues Resolved
Platforms Affected
Testing Procedure
PR Checklist