This repository has been archived by the owner on May 1, 2024. It is now read-only.
[iOS] Fix non visible TextColor issue in Entry using Visual #13051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
added
the
i/high
PureWeen
approved these changes
Dec 18, 2020
hartez
approved these changes
Dec 18, 2020
|
Failing tests not related |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The main issue is solved in native Material Components iOS library:
https://github.com/material-components/material-components-ios/issues/10081
We did a color workaround #12246 to avoid the issue but we will investigate in release new binding for Material Components library. This PR just include a small change in the color workaround to fix the entry text no visible issue using the default color for now.
The default color alpha is -1, and that's why we set the default alpha to zero in the color workaround.
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Testing Procedure
Launch Core Gallery and navigate to the issue 12809 on iOS simulator or device. Write in each Entry and verify that the text color is always visible.
PR Checklist