Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Fix cast of non appcompat renderer to DrawerLayout #13084

Merged
merged 1 commit into from
Dec 10, 2020

Conversation

PureWeen
Copy link
Contributor

@PureWeen PureWeen commented Dec 8, 2020

Description of Change

The NonAppCompat version of MDP was trying to cast its renderer to FlyoutPageRenderer but that's not a valid renderer for the Non AppCompat version of MDP. This changes the cast to be to a DrawerLayout which is the actual type trying to be achieved

Platforms Affected

  • Android

Testing Procedure

Here's the code from the gallery I was using to test this code

SetMainPage(new MasterDetailPage()
			{
				IconImageSource = "coffee.png",
				Master = new NavigationPage(new ContentPage()
				{
					Title = "test",
					Content = new Button()
					{
						Text = "hello",
						Command = new Command(() =>
						{
							(Application.Current.MainPage as MasterDetailPage)
							.Detail = new NavigationPage(new ContentPage() { Title = "test" });
						}
						)
					}
				})
				{
					IconImageSource = "coffee.png",
					Title = "Master Page"
				},
				Detail = new ContentPage() { Title = "test" },
			});

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@PureWeen PureWeen added the blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. label Dec 8, 2020
@PureWeen PureWeen added this to To do in vNext+1 (5.0.0) via automation Dec 8, 2020
@PureWeen PureWeen added this to the 5.0.0 milestone Dec 8, 2020
@PureWeen PureWeen moved this from To do to In Review in vNext+1 (5.0.0) Dec 10, 2020
@rmarinho rmarinho merged commit 259a412 into 5.0.0 Dec 10, 2020
vNext+1 (5.0.0) automation moved this from In Review to Done Dec 10, 2020
@rmarinho rmarinho deleted the fix_non_appcompat_mdp branch December 10, 2020 10:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a/masterdetailpage blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. p/Android
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants