This repository has been archived by the owner on May 1, 2024. It is now read-only.
[iOS/macOS] Same offsets behavior in GradientBrush between platforms #13101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
changed the title
rmarinho
added
the
blocker
rmarinho
approved these changes
Dec 13, 2020
mattleibow
reviewed
Dec 15, 2020
There was a problem hiding this comment.
Looking at the code, they are the same. Is there no way to move this into a CAUtils or something?
Also, the adjacent GetRadialGradientBrushEndPoint methods differ already. macOS has additional checks that might also be needed in the iOS side. Or at least have some sort of extension method for these types that can be shared if possible.
|
@mattleibow Thanks for the feedback!. I have created a shared |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
On Android, using a
GradientDrawablerenders the gradient even without setting the offsets. On iOS (or macOS), the gradient does not render without setting the offsets.This PR adds changes to set the default values in case of not having any offset set in the Brush. In this way, we have the same behavior between different platforms.
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Testing Procedure
Launch Core Gallery and navigate to the Brushes samples. Select the new "GradientBrush Offsets Gallery" to verify that the gradient is rendered in the same way on iOS (and macOS) as on Android.
PR Checklist