Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[iOS] Device.OpenUriAction can open tel URIs with spaces again #1311

Merged
merged 11 commits into from Mar 23, 2018
Merged

[iOS] Device.OpenUriAction can open tel URIs with spaces again #1311

merged 11 commits into from Mar 23, 2018

Conversation

samhouts
Copy link
Member

@samhouts samhouts commented Nov 30, 2017 •
edited

Description of Change

#734 enabled users to open URLs on iOS while properly passing the query strings.

NSUrl is not happy when tel paths have spaces, however, so it crashes when attempting to parse it.

Since tel paths won't have query strings, using the AbsoluteUri to let it encode properly.

Note: this is #1296 pointed at 15-5.

Bugs Fixed

API Changes

None

Behavioral Changes

None

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

@samhouts samhouts added the DO-NOT-MERGE-!!! 🛑 This is in progress and needs to be updated before it can be merged. label Nov 30, 2017
@samhouts samhouts removed the DO-NOT-MERGE-!!! 🛑 This is in progress and needs to be updated before it can be merged. label Jan 25, 2018
@rmarinho
Copy link
Member

rmarinho commented Feb 2, 2018

@samhouts can you take at failures for Android please.

@samhouts samhouts added the DO-NOT-MERGE-!!! 🛑 This is in progress and needs to be updated before it can be merged. label Feb 9, 2018
@samhouts samhouts added this to Ready in v3.0.0 via automation Mar 13, 2018
@samhouts samhouts moved this from Ready to In Progress in v3.0.0 Mar 13, 2018
@rmarinho rmarinho moved this from In Progress to In Review in v3.0.0 Mar 15, 2018
@samhouts samhouts moved this from In Review to In Progress in v3.0.0 Mar 15, 2018
@rmarinho
Copy link
Member

build --uitests

@samhouts samhouts changed the base branch from 15-5 to 3.0.0 March 20, 2018 18:20
@samhouts
Copy link
Member Author

build --uitests

@samhouts
Copy link
Member Author

samhouts commented Mar 21, 2018 •
edited

Ok, as of now, I have all green tests except for iOS11. I suspect that the Isolate test is not working there. Requires more investigation before we merge.

Edit: Oh, I see, iOS 11 shows a dialog that never goes away until you dismiss it if you try to open the phone. Great.

@samhouts samhouts removed the DO-NOT-MERGE-!!! 🛑 This is in progress and needs to be updated before it can be merged. label Mar 21, 2018
@samhouts
Copy link
Member Author

build --uitests

@samhouts samhouts moved this from In Progress to In Review in v3.0.0 Mar 21, 2018
@samhouts
Copy link
Member Author

build --uitests

@rmarinho rmarinho merged commit 85607dc into 3.0.0 Mar 23, 2018
v3.0.0 automation moved this from In Review to Done Mar 23, 2018
@rmarinho rmarinho mentioned this pull request Mar 23, 2018
Closed
@samhouts samhouts deleted the fix-bugzilla60691-2 branch March 23, 2018 17:27
@samhouts samhouts added this to the 3.0.0 milestone May 5, 2018
StephaneDelcroix added a commit that referenced this pull request May 9, 2018
@StephaneDelcroix
[iOS] allow mailto: uri
5af1326 
same as #1311 but for mailto:

 - fixes #2628
@StephaneDelcroix StephaneDelcroix mentioned this pull request May 9, 2018
Merged
4 tasks
StephaneDelcroix added a commit that referenced this pull request May 11, 2018
@StephaneDelcroix
[iOS] allow mailto: uri (#2646)
501e54c 
* [iOS] allow mailto: uri

same as #1311 but for mailto:

 - fixes #2628

* Add mailto test
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@StephaneDelcroix StephaneDelcroix StephaneDelcroix approved these changes

@rmarinho rmarinho rmarinho approved these changes

Assignees
No one assigned
Labels
p/iOS 🍎 t/bug 🐛
Projects
No open projects
v3.0.0
  
Done
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@samhouts @rmarinho @StephaneDelcroix @dnfadmin @dnfclas