This repository has been archived by the owner on May 1, 2024. It is now read-only.
Fix semaphore issues updating CollectionView on iOS #13119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alls that were messing up the internal UICollectionView bookkeeping; fixes #11853
This was
linked to
issues
Dec 13, 2020
rmarinho
suggested changes
Dec 14, 2020
jsuarezruiz
added
a/collectionview
i/high
jsuarezruiz
suggested changes
Dec 15, 2020
Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue11853.xaml.cs
Show resolved
Hide resolved
hartez
added
the
blocker
rmarinho
approved these changes
Dec 15, 2020
|
Seems tests are working fine: |
jsuarezruiz
approved these changes
Dec 16, 2020
|
Could this PR fix #10329? |
|
@hartez seems some tests are failing ios11 and ios12 CarouselViewPositionFromVisibilityChangeTest_apple_iphone_x_11_4_1 |
Tested, and it doesn't. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This is a partial backport of the fixes from PR #12837; some of the changes necessary for that fix also addressed the problems pointed out in #11853. These changes apply those fixes to version 4.8.
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
Testing Procedure
Automated UI test
PR Checklist