This repository has been archived by the owner on May 1, 2024. It is now read-only.
[UWP] Fixed NRE load image from ImageSource #13135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @jsuarezruiz is it possible to add a UITest ? |
|
Sure, added!. |
rmarinho
added
the
blocker
rmarinho
suggested changes
Dec 16, 2020
rmarinho
suggested changes
Dec 18, 2020
|
@jsuarezruiz i comment your change and the test still passes, am i holding it wrong ? |
rmarinho
approved these changes
Dec 18, 2020
There was a problem hiding this comment.
I tested the nuget on the issue and it solves the issue. But that said the UITest added is not really testing this issue since Application is not null if we do it from the Xamarin.Forms side .
I also think this should target 4.8.0 , since is ra regression there
hartez
approved these changes
Dec 18, 2020
|
@jsuarezruiz tests is failing on UWP |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixed NRE load image from ImageSource in UWP.
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
Testing Procedure
Launch Core Gallery and navigate to the issue 13109. Without exceptions, the test has passed.
PR Checklist