Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[iOS] NavigationPage.HideNavigationBarSeparator="true" #13139

Merged
merged 2 commits into from
Dec 16, 2020
Merged

Conversation

jsuarezruiz
Copy link
Contributor

@jsuarezruiz jsuarezruiz commented Dec 14, 2020

Description of Change

Cannot reproduce the issue with Xamarin.Forms 5.0-pre NuGet package nor in the 5.0.0 branch. For that reason, this PR only include a sample where validate the issue.

Issues Resolved

API Changes

None

Platforms Affected

  • iOS

Behavioral/Visual Changes

None

Before/After Screenshots

issue10578

Testing Procedure

Launch Core Gallery and navigate to the issue 10578. If the NavigationBar Separator is hidden, the test has passed.

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@jsuarezruiz jsuarezruiz changed the title Added repro sample [iOS] NavigationPage.HideNavigationBarSeparator="true" Dec 14, 2020
@jsuarezruiz jsuarezruiz added the blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. label Dec 14, 2020
@rmarinho rmarinho merged commit 8823018 into 5.0.0 Dec 16, 2020
@rmarinho rmarinho deleted the fix-10578 branch December 16, 2020 23:48
@samhouts samhouts added this to the 5.0.0 milestone Dec 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a/navbar a/Xaml </> blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. m/high impact ⬛ p/iOS 🍎 t/bug 🐛
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug][iOS] NavigationPage.HideNavigationBarSeparator="true" doesn't work from XAML
3 participants