This repository has been archived by the owner on May 1, 2024. It is now read-only.
[iOS] Allow VC renderers of FlyoutPage to specify UIStatusBarStyle #13143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hartez
suggested changes
Jan 22, 2021
|
|
||
| public override UIViewController ChildViewControllerForStatusBarStyle() | ||
| { | ||
| return ChildViewControllers?.LastOrDefault() ?? base.ChildViewControllerForStatusBarStyle(); |
There was a problem hiding this comment.
ChildViewControllers is an array - can we just check the last index instead of allocating an enumerator?
Also, are we guaranteed that the last controller in the array is the correct one?
There was a problem hiding this comment.
Fixed it @hartez , this ChildVIewController wrapper is internal and we are the only ones adding to it the detail or flout as a children, it's the only children.
|
Is it possible that a fix like this would be needed for the Shell too? I'm using a Shell and cannot change the color of the status bar text using PreferredStatusBarStyle on any of the pages I navigate to |
jfversluis
approved these changes
Jan 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Since we were wrapping the renderers of FlyoutPage and DetailPage on a internal ViewController, the users couldn't provide overrides for
PreferredStatusBarStyle().To fix this we override
ChildViewControllerForStatusBarStyleon our internalChildViewControllerand point to page's VC.Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
Should be able to provide UIStatusBar color
Before/After Screenshots
Before:
After:
Testing Procedure
Start the ControlGallery and check if the UIStatus bar shows white content on the left, and black content on the right.
PR Checklist