Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

More efficiently process rapid Flyout Item Changes #13145

Merged
merged 3 commits into from
Dec 15, 2020
Merged

More efficiently process rapid Flyout Item Changes #13145

merged 3 commits into from
Dec 15, 2020

Conversation

PureWeen
Copy link
Contributor

Description of Change

When the user was rapidly changing Flyout Item it would occasionally cause the content to become blank. These changes better stream line processing ShellItem changes relative to the animation used to process those changes. If the user changed back to a previous FlyouItem mid transition then a second renderer would get created for a flyout item that hadn't yet been removed.

Issues Resolved

Platforms Affected

  • iOS

Testing Procedure

  • automated test included

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@PureWeen PureWeen added 5.0.0 Regression on 5.0.0 blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. and removed 5.0.0 Regression on 5.0.0 labels Dec 15, 2020
@PureWeen PureWeen added this to To do in vNext+1 (5.0.0) via automation Dec 15, 2020
@PureWeen PureWeen added this to the 5.0.0 milestone Dec 15, 2020
@rmarinho rmarinho moved this from To do to In Review in vNext+1 (5.0.0) Dec 15, 2020
Copy link
Contributor

@jsuarezruiz jsuarezruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix13068

@PureWeen
Copy link
Contributor Author

@rmarinho rmarinho merged commit ee18e49 into 5.0.0 Dec 15, 2020
vNext+1 (5.0.0) automation moved this from In Review to Done Dec 15, 2020
@rmarinho rmarinho deleted the fix_13068 branch December 15, 2020 23:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a/shell 🐚 blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. p/iOS 🍎
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

[Bug][iOS][Shell] Rapid Navigation Between FlyoutItems Creates Blank Pages With Missing Renderers
4 participants