Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Fix Flyout Footer measuring and Content Margin #13157

Merged
merged 2 commits into from
Dec 17, 2020
Merged

Fix Flyout Footer measuring and Content Margin #13157

merged 2 commits into from
Dec 17, 2020

Conversation

PureWeen
Copy link
Contributor

Description of Change

  • Open up a few renderer APIs to make it easier to customize parts of the Shell Flyout
  • Fix measuring on the footer to pass in double.Infinity instead of -1.
  • Set the bottom margin on the content inside the flyout so it doesn't flow behind the footer view

API Changes

Added:

  • protected virtual ShellFlyoutTemplatedContentRenderer.ShellContext
  • protected virtual ShellFlyoutTemplatedContentRenderer.FooterView
  • protected virtual ShellFlyoutTemplatedContentRenderer.View
  • protected virtual ShellFlyoutTemplatedContentRenderer.UpdateFlyoutHeader()
  • protected virtual ShellFlyoutTemplatedContentRenderer.UpdateFlyoutFooter()
  • protected virtual ShellItemRenderer.UpdateTabBarVisibility()

Platforms Affected

  • Android

Testing Procedure

  • UI Test included

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@PureWeen PureWeen added this to To do in vNext+1 (5.0.0) via automation Dec 16, 2020
@PureWeen PureWeen moved this from To do to In Review in vNext+1 (5.0.0) Dec 16, 2020
@PureWeen PureWeen added this to the 5.0.0 milestone Dec 16, 2020
@PureWeen PureWeen added the blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. label Dec 16, 2020
jsuarezruiz
jsuarezruiz approved these changes Dec 17, 2020
View reviewed changes
Xamarin.Forms.Platform.Android/Renderers/ShellViewRenderer.cs
return;
}

var request = View.Measure(width, height, MeasureFlags.None);

var layoutParams = NativeView.LayoutParameters;
if (height == -1)
if (double.IsInfinity(height))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@rmarinho rmarinho merged commit 298e62a into 5.0.0 Dec 17, 2020
vNext+1 (5.0.0) automation moved this from In Review to Done Dec 17, 2020
@rmarinho rmarinho deleted the flyout_footer_fixes branch December 17, 2020 10:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pictos pictos pictos left review comments

@rmarinho rmarinho rmarinho approved these changes

@jsuarezruiz jsuarezruiz jsuarezruiz approved these changes

Assignees
No one assigned
Labels
a/shell 🐚 blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue.
Projects
No open projects
vNext+1 (5.0.0)
Done
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@PureWeen @rmarinho @jsuarezruiz @pictos