This repository has been archived by the owner on May 1, 2024. It is now read-only.
Add new xplat event to to propagate FlyoutItemsChanged events to the platforms #13195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
added
a/shell 🐚
blocker
|
Test failures unrelated |
rmarinho
approved these changes
Dec 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Added an event to IShellController that can specifically be used to indicate FlyoutItems have changed. Currently this is based on the StructureChanged event but as of 4.6 the StructureChanged event only fires for currently visible pages. This was changed in 4.6 because it was sending a "StructureChanged" event every time you added a new Shell Element which was causing some performance issues and visual artifacts. These changes also for intelligently fire the FlyoutItem changed event when it detects that the list of Flyout Items has actually changed opposed to just firing it off all of the time
Converted the Flyout Items on UWP shell to use an ObservableCollection. NavigationView doesn't really do very well if you just swap out the Source.
Issues Resolved
API Changes
Added:
Platforms Affected
Testing Procedure
PR Checklist