Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Add Exception Message when trying to use FlyoutPage with NonAppCompat #13259

Merged
merged 3 commits into from
Jan 1, 2021

Conversation

PureWeen
Copy link
Contributor

Description of Change

As part of the shift to FlyoutPage from MasterDetailPage we only moved over the AppCompat renderers so if someone is still on non appcompat and tries to use FlyoutPage they will just get a blank screen. This PR will give them a more useful message.

Platforms Affected

  • Android

Testing Procedure

  • Make sure Flyout Page still works with AppCompat (and other platforms)
  • Verify Exception Message when switching to non appcompat

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@PureWeen PureWeen added this to the 5.0.0 milestone Dec 31, 2020
@PureWeen PureWeen added this to To do in vNext+1 (5.0.0) via automation Dec 31, 2020
@PureWeen
Copy link
Contributor Author

PureWeen commented Jan 1, 2021

Test Failures Unrelated

@rmarinho rmarinho merged commit f9b5018 into 5.0.0 Jan 1, 2021
vNext+1 (5.0.0) automation moved this from To do to Done Jan 1, 2021
@rmarinho rmarinho deleted the fp_nonappcompat_exception branch January 1, 2021 18:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants