This repository has been archived by the owner on May 1, 2024. It is now read-only.
Invoke AnimationFinished from fragment if no animation has been added #13260
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
ShellItemRenederer on Android let's users override
SetupAnimation
to define custom animations. The navigation code on android subscribes to "AnimationFinished" to know when the animation has finished and complete the navigation Task. The problem here is that if the SetupAnimation doesn't actually setup an animation then "AnimationFinished" never gets called from ShellContentFragment. The real fix here will be to add a better API for the SetupAnimation override. Currently it's justBut it should really be something like
Or something similar to indicate to the caller that they need to tell the calling code when the animation has completed.
Platforms Affected
Testing Procedure
PR Checklist