This repository has been archived by the owner on May 1, 2024. It is now read-only.
[UWP] Fixes to Cell for ListView and CollectionView #13277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o a XF PR. These have been tested and seem work solve the issue of the Cell not being disposed of as they are now reused rather than created from scratch. I am only putting forward the PR.
rmarinho
reviewed
Jan 4, 2021
FIxed so that it's now reverted to the current live version of the file...
|
here you go @rmarinho I reverted the changes I have no idea how or why that file was changed but it's back to how it was and only the one file is now changed which is the one that should I hope fix the UWP Memory leak. |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 13277 in repo xamarin/Xamarin.Forms |
hartez
approved these changes
Jan 5, 2021
samhouts
added
p/UWP
a/listview
rmarinho
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix for #10473 that is a massive blocker for UWP development using List and Collection views in XF. This fix was designed by @gentledepp and I am putting it forward as a PR to the main XF repo as they had only made the changes to thier company fork. I have tested these changes and they seem to fix the issue on the project we are building.
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
PR Checklist