Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Isolate the TemplatedView check inside Platform.cs to just RadioButton until we can provide a more generalized fix #13279

Merged
merged 6 commits into from
Jan 5, 2021
Merged

Isolate the TemplatedView check inside Platform.cs to just RadioButton until we can provide a more generalized fix #13279

merged 6 commits into from
Jan 5, 2021

Conversation

PureWeen
Copy link
Contributor

@PureWeen PureWeen commented Jan 4, 2021

Description of Change

Isolate the TemplatedView check inside Platform.cs to just RadioButton for now to accommodate the two fixes referenced in this issue. The issue with the changes inside Platform.cs means that if someone inherits from TemplatedView and registers a custom renderer it won't use that CustomRenderer it will just use a DefaultRenderer.

Issues Resolved

Platforms Affected

  • Android

Testing Procedure

  • UI Test included
  • Test Templating with RadioButton (Automated test incoming)

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@PureWeen
Copy link
Contributor Author

PureWeen commented Jan 4, 2021

https://dev.azure.com/xamarin/public/_apps/hub/ms.vss-releaseManagement-web.cd-release-progress?_a=release-pipeline-progress&releaseId=2709

@PureWeen PureWeen merged commit cfd463f into 5.0.0 Jan 5, 2021
@PureWeen PureWeen deleted the fix_13261 branch January 5, 2021 02:21
@samhouts samhouts added this to the 5.0.0 milestone Jan 5, 2021
@PureWeen PureWeen mentioned this pull request Jan 7, 2021
Open
@samhouts samhouts added a/customrenderer blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. i/regression t/bug 🐛 5.0.0 Regression on 5.0.0 labels Jan 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rmarinho rmarinho rmarinho approved these changes

@hartez hartez Awaiting requested review from hartez

Assignees
No one assigned
Labels
5.0.0 Regression on 5.0.0 a/customrenderer blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. i/regression t/bug 🐛
Projects
None yet
Milestone
5.0.0
3 participants
@PureWeen @rmarinho @samhouts