Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Tizen] Fix Frame show clipper canvas issue #13335

Merged
merged 1 commit into from
Jan 10, 2021

Conversation

JoonghyunCho
Copy link
Contributor

Description of Change

This PR fixes Frame not creating unused clipper.
The clipper only needs to be created when Frame has Content.
Otherwise, white color clipper will be unexpectedly drawn in Frame as background.

Issues Resolved

  • N/A

API Changes

  • None

Platforms Affected

  • Tizen

Behavioral/Visual Changes

Before:

  1. Frame without Content : This includes white background which is unexpected.
  2. Frame with BackgroundColor which has alpha : The background blends with white background which is unexpected.
  3. Frame with Content : Proper behavior.
    image

After:

  1. Frame without Content : This includes empty background. (Proper behavior.)
  2. Frame with BackgroundColor which has alpha : The background blends with real background. (Proper behavior.)
  3. Frame with Content : (Proper behavior.)
    image

Testing Procedure

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@rookiejava rookiejava self-requested a review January 8, 2021 08:30
Copy link
Collaborator

@rookiejava rookiejava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! Thanks.

@rmarinho rmarinho merged commit d6e6b37 into xamarin:5.0.0 Jan 10, 2021
@samhouts samhouts added this to the 5.0.0 milestone Jan 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants