Remove unnecessary edge inset for vertically scrolling groups; Fixes …

[hartez]

Description of Change

The UIEdgeInsets adjustment to make spacing between group headers and the group itself was adding the horizontal item spacing value to the left edge of vertically scrolling groups. These changes remove that unnecessary extra space (which, in addition to making the left edge of the group offset incorrectly, also would cause the last column of a grid layout to move to the next row).

Issues Resolved

• fixes [Bug] CollectionView with Grouping and GridItemLayout displays wrong number of columns on IOS #13347

API Changes

None

Platforms Affected

• iOS

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

Control Gallery -> CollectionView Gallery -> Grouping Galleries -> Grouping, Grid

There should be two columns of items in each group; if there's just one, this is still broken.

PR Checklist

• Targets the correct branch
• Tests are passing (or failures are unrelated)

[PureWeen]

@hartez when you scroll the CollectionView the sum part at the bottom fluctuates between one to two columns. New Issue? Or should that be fixed as part of this issue?

[rachelkang]

seeing the exact same behavior (2 columns instead of 1), including the bug @PureWeen described on 4.8.0 branch generally

[hartez]

@PureWeen @rachelkang Yes, this should be addressed in another PR.

I created an issue for it: #13464

[rachelkang]

@hartez is there a project / test file we can test against? The testing procedure detailed passes fine without this fix as well

[hartez]

@hartez is there a project / test file we can test against? The testing procedure detailed passes fine without this fix as well

I added HorizontalItemSpacing="5" to the test screen in the PR. The screenshots below are the before (left) and after (right):

[hartez]

Failing tests are unrelated.