This repository has been archived by the owner on May 1, 2024. It is now read-only.
[Android] Changes in CarouselView initial position #13384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmarinho
reviewed
Jan 13, 2021
| break; | ||
| } | ||
| if(carouselEnumerator.Current == Carousel.CurrentItem) | ||
| position = itemCount; |
There was a problem hiding this comment.
Shouldn't this break so it doesn't loop the full collection ?
There was a problem hiding this comment.
We need itemCount right after this iteration, so we need it to complete the loop.
rmarinho
approved these changes
Jan 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Recently, fixing a TabView issue xamarin/XamarinCommunityToolkit#630 (which internally uses CarouselView) in the Xamarin Community Toolkit, I noticed some unexpected behavior with the initial position of the CarouselView.
The problem is that the casting:
var items = Carousel.ItemsSource as IList;It is not correct in all cases. This PR adds changes to use an enumerator.
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
PR Checklist