Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Android] Fix swipe issue using SwipeView inside TabbedPage using IsSwipePagingEnabled #13404

Merged
merged 8 commits into from
Oct 18, 2021

Conversation

jsuarezruiz
Copy link
Contributor

Description of Change

Fix swipe issue using SwipeView inside TabbedPage using IsSwipePagingEnabled on Android.

Issues Resolved

API Changes

None

Platforms Affected

  • Android

Behavioral/Visual Changes

None

Before/After Screenshots

fix13337

And the behavior with a TabbedPage with swipe gesture enabled.
sw-tp-behavior

Testing Procedure

Launch Core and navigate to the issue 13337. Interact with the SwipeView available in Page 2 and then, try to swipe to move between tabs. If the page not swipe, the test has passed.

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@jsuarezruiz
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@justinasfour04
Copy link

@jsuarezruiz when is this going to included in the new release

@AlleSchonWeg
Copy link
Contributor

Hi @jfversluis,

could you create a nuget for me? I think this PR could fix 3 open issues.

@jfversluis
Copy link
Member

@AlleSchonWeg I can create your NuGet here, but just to be clear: I will stop adding the things you tag me in for the next service release. I already snuck in a couple, for now focus is on the other issues I have already pointed out. Thanks :)

@AlleSchonWeg
Copy link
Contributor

@jfversluis
I'm currently working with SwipeView and implemented a couple of workarounds. So it's easy for me to test the nugets. I just want to help other devs and me ;)
This nuget is ok. Fixes the problems.

@jfversluis
Copy link
Member

Perfect! And please keep continue doing so. Just wanted to set expectations :)

@jfversluis jfversluis merged commit 8068615 into 5.0.0 Oct 18, 2021
@jfversluis jfversluis deleted the fix-13337 branch October 18, 2021 18:36
@tranb3r
Copy link

tranb3r commented Nov 16, 2021

I've just updated XF to 5.0.0.2244. The bug is still here (in my app).
@jfversluis Could you please confirm the fix is working and has really been merged into SR7 ?

@jfversluis
Copy link
Member

Very sure! Did you check earlier test versions? Did those work? Maybe your issue is slightly different?

@tranb3r
Copy link

tranb3r commented Nov 16, 2021

Yes, you're right, my issue is slightly different: the SwipeView is inside a ScrollView (and inside TabbedPage of course).
Without the ScollView, the fix works. With the ScrollView, the fix does not work.
I guess when I checked the test version, I didn't have the ScrollView in the tab content yet.
Should I open a new issue ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
6 participants