-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[Android] Fix swipe issue using SwipeView inside TabbedPage using IsSwipePagingEnabled #13404
Conversation
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@jsuarezruiz when is this going to included in the new release |
Hi @jfversluis, could you create a nuget for me? I think this PR could fix 3 open issues. |
@AlleSchonWeg I can create your NuGet here, but just to be clear: I will stop adding the things you tag me in for the next service release. I already snuck in a couple, for now focus is on the other issues I have already pointed out. Thanks :) |
@jfversluis |
Perfect! And please keep continue doing so. Just wanted to set expectations :) |
I've just updated XF to 5.0.0.2244. The bug is still here (in my app). |
Very sure! Did you check earlier test versions? Did those work? Maybe your issue is slightly different? |
Yes, you're right, my issue is slightly different: the SwipeView is inside a ScrollView (and inside TabbedPage of course). |
Description of Change
Fix swipe issue using SwipeView inside TabbedPage using
IsSwipePagingEnabled
on Android.Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
And the behavior with a TabbedPage with swipe gesture enabled.
![sw-tp-behavior](https://user-images.githubusercontent.com/6755973/104613381-78ab5480-5687-11eb-95fb-0481581e72c6.gif)
Testing Procedure
Launch Core and navigate to the issue 13337. Interact with the SwipeView available in Page 2 and then, try to swipe to move between tabs. If the page not swipe, the test has passed.
PR Checklist