Don't set IsAccessibilityElement for everything

[PureWeen]

Description of Change

The original comment says this

		// UIKit UIViews created via storyboard default IsAccessibilityElement to true, BUT	
			// UIViews created programmatically default IsAccessibilityElement to false.	
			// We need to default to true to allow all elements to be accessible by default and	
			// allow users to override this later via AutomationProperties.IsInAccessibleTree

I don't feel like that's completely accurate. If you inspect IsAccessibilityElement directly after instantiating a control then it is indeed false but by the time the control is rendering it is set to the correct value for the given control. If you breakpoint SetAccessibilityElement inside the Automation Extensions you will see that IsAccessibilityElement is true when it should be true and false when it should be false

There are certain controls (UIScrollView, ListView, really anything that's a container of views) that should always remain false. If they get set to true then it causes all the content inside the view to become unreachable.

Just let the OS do what the OS is going to do

Issues Resolved

• fixes [Bug][Accessibility] iOS CollectionView with VoiceOver not usable in Xamarin.Forms 4.8 #12252

Platforms Affected

• iOS

Testing Procedure

• Test any of the collection view samples using voice over and make sure they still work
• Test all samples that are voice over related and make sure they still work

PR Checklist

• Targets the correct branch
• Tests are passing (or failures are unrelated)

[rachelkang]

Some previously accessible things are no longer accessible

i.e. Open iOS ControlGallery >> CollectionView Gallery
The various buttons linking to different CV sample galleries are no longer accessible. Where they were previously focusable with VO, they no longer are. Will these issues be resolved elsewhere? If not, can we move this bit of code to several other areas where they may still be applicable?

[rachelkang]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[PureWeen]

Failing tests unrelated