Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[iOS] Fix wrong points transformation in GeometryExtensions #13460

Merged
merged 3 commits into from
May 4, 2021

Conversation

jsuarezruiz
Copy link
Contributor

Description of Change

Fix wrong points transformation in GeometryExtensions on iOS.

Issues Resolved

API Changes

None

Platforms Affected

  • iOS

Behavioral/Visual Changes

None

Before/After Screenshots

Captura de pantalla 2021-01-19 a las 17 55 22

Testing Procedure

Launch Core Gallery and navigate to the issue 13315. If the Paths render exactly the same on all platforms, the test has passed.

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@jsuarezruiz
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rachelkang
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@rachelkang rachelkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CG looks great, but nuget fix doesn't appear to affect original repro sample. Need to rebuild and test again with refreshed nuget

@rmarinho
Copy link
Member

rmarinho commented May 4, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).


namespace Xamarin.Forms.Controls.Issues
{
[Issue(IssueTracker.Github, 13315,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: should this all be on one line?

Copy link
Contributor

@rachelkang rachelkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jsuarezruiz jsuarezruiz merged commit 535679a into 5.0.0 May 4, 2021
@jsuarezruiz jsuarezruiz deleted the fix-13315 branch May 4, 2021 17:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Path renders incorrectly on iOS but correctly on Android
3 participants