This repository has been archived by the owner on May 1, 2024. It is now read-only.
Setup Shell to only use the LogicalChildren for reporting its LogicalChildren #13462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
added
the
DO-NOT-MERGE-!!! 🛑
PureWeen
commented
Jan 20, 2021
| @@ -379,7 +379,7 @@ protected void UpdateChildrenLayout() | |||
| var element = LogicalChildren[i]; | |||
| if (element is VisualElement c) | |||
| { | |||
| if (c.Bounds != startingLayout[i]) | |||
| if (startingLayout.Count <= i || c.Bounds != startingLayout[i]) | |||
There was a problem hiding this comment.
Now that generated flyout items are added to the LogicalChildren the startingLayout.Count no longer matches up with LogicalChildren.Count after LayoutChildren is called
PureWeen
changed the title
PureWeen
added
blocker
StephaneDelcroix
approved these changes
Jan 22, 2021
BretJohnson
approved these changes
Jan 22, 2021
drasticactions
approved these changes
Jan 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Shift Shell over so it returns everything from the Logical Children structure which plays into Hot Reload and the Live Visual Tree better. Initially I didn't use LogicalChildren because Page (the base class of Shell) makes a bunch of assumptions against its LogicalChildren. This PR intercepts those assumptions and just lets Shell manage its logical children
Issues Resolved
Testing Procedure
PR Checklist