[X] Accept RD.Source with assembly #13484
Conversation
| asmName = parts[1]; | ||
| if (currentModule.Assembly.Name.Name != asmName) | ||
| { | ||
| var ar = currentModule.AssemblyReferences.FirstOrDefault(ar => ar.Name == asmName); |
There was a problem hiding this comment.
Should we check if the assembly exists ? And throw a more meaningful error if it doesn't , let's say i set something like:
SharedResourceDictionary.xaml;assembly=FooWithANNamingError",
There was a problem hiding this comment.
you get ResourceMissing. We could have a specialised message, but not in a -sr (as it involves translation)
There was a problem hiding this comment.
I tried to add a comment here but must have missed to submit it.
Wouldn't it be safer to split the string on ';' and parse the left and right parts independently? The code right now assumes that 'assembly=xxx;' is the last parameter. It will also crash if 'assembly=' is used, which to the best of my knowledge is valid and should just be ignored. So a future-proof parsing would be to just split on ';'.
samhouts
added
partner
Description of Change
[X] Accept RD.Source with assembly
this also always add the assembly part in the Source url
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
Testing Procedure
PR Checklist