Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Fix popping with ".." and QueryString #13507

Merged
merged 2 commits into from
Feb 4, 2021
Merged

Fix popping with ".." and QueryString #13507

merged 2 commits into from
Feb 4, 2021

Conversation

PureWeen
Copy link
Contributor

Description of Change

When processing a ".." operation to recalculate the new shell path query strings were incorrectly being processed as part of the path. The changes in this PR properly process only the path part when recalculating the destination path

Issues Resolved

Platforms Affected

  • Core/XAML (all platforms)

Testing Procedure

  • unit test included

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@PureWeen PureWeen removed the request for review from StephaneDelcroix January 22, 2021 21:23
@PureWeen PureWeen added the blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. label Jan 22, 2021
@PureWeen PureWeen added this to To do in vNext+1 (5.0.0) via automation Jan 22, 2021
@PureWeen PureWeen added this to the 5.0.0 milestone Jan 22, 2021
@PureWeen PureWeen moved this from To do to In Review in vNext+1 (5.0.0) Jan 23, 2021
@hartez hartez added this to To Fix in 5.0.0 SR 3 via automation Feb 2, 2021
@hartez hartez moved this from To Fix to PR Needs Review in 5.0.0 SR 3 Feb 2, 2021
@hartez hartez removed this from In Review in vNext+1 (5.0.0) Feb 2, 2021
@hartez hartez moved this from PR Needs Review to PR Build/Test Failures in 5.0.0 SR 3 Feb 2, 2021
5.0.0 SR 3 automation moved this from PR Build/Test Failures to Merge it! Feb 2, 2021
@hartez hartez moved this from Merge it! to PR Needs Review in 5.0.0 SR 3 Feb 2, 2021
@hartez hartez moved this from PR Needs Review to PR Build/Test Failures in 5.0.0 SR 3 Feb 3, 2021
@PureWeen PureWeen mentioned this pull request Feb 3, 2021
Closed
@PureWeen PureWeen moved this from PR Build/Test Failures to PR Needs Review in 5.0.0 SR 3 Feb 3, 2021
@PureWeen
Copy link
Contributor Author

PureWeen commented Feb 3, 2021

Test failure unrelated

@rachelkang rachelkang self-requested a review February 4, 2021 00:25
@PureWeen PureWeen merged commit 26b06da into 5.0.0 Feb 4, 2021
5.0.0 SR 3 automation moved this from PR Needs Review to Done Feb 4, 2021
@PureWeen PureWeen deleted the fix_13506 branch February 4, 2021 00:48
@dependabot dependabot bot mentioned this pull request Mar 18, 2021
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hartez hartez hartez approved these changes

@rachelkang rachelkang rachelkang approved these changes

Assignees
No one assigned
Labels
a/shell 🐚 blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. t/bug 🐛
Projects
No open projects
5.0.0 SR 3
Done
Milestone
5.0.0
4 participants
@PureWeen @hartez @rachelkang @samhouts