Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Android] Fix TalkBack to read back button title when it is set #13563

Merged
merged 5 commits into from
Feb 2, 2021
Merged

[Android] Fix TalkBack to read back button title when it is set #13563

merged 5 commits into from
Feb 2, 2021

Conversation

rachelkang
Copy link
Contributor

Description of Change

TalkBack would read back button as 'Unlabeled button' even when a back button title is set.
Now, TalkBack will read the back button title when it is set.

Issues Resolved

Platforms Affected

  • Android

Testing Procedure

  • Set main page to Issue8701 > Run on Android > Follow on-screen instructions

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@rachelkang rachelkang added a/a11y 🔍 a/backbutton i/high Completely doesn't work, crashes, or is unusably slow, has no obvious workaround; occurs less often p/Android labels Jan 27, 2021
@rachelkang rachelkang mentioned this pull request Jan 27, 2021
Closed
@rachelkang rachelkang added this to In Review in Accessibility via automation Jan 28, 2021
@rachelkang rachelkang added this to To do in vNext+1 (5.0.0) via automation Jan 28, 2021
@rachelkang rachelkang moved this from To do to In Review in vNext+1 (5.0.0) Jan 28, 2021
@hartez hartez added this to To Fix in 5.0.0 SR 3 via automation Feb 2, 2021
@hartez hartez removed this from In Review in vNext+1 (5.0.0) Feb 2, 2021
@hartez hartez moved this from To Fix to PR Needs Review in 5.0.0 SR 3 Feb 2, 2021
@PureWeen PureWeen merged commit d10e518 into 5.0.0 Feb 2, 2021
Accessibility automation moved this from In Review to Done Feb 2, 2021
@PureWeen PureWeen deleted the issue-8701 branch February 2, 2021 23:55
5.0.0 SR 3 automation moved this from PR Needs Review to Done Feb 2, 2021
@samhouts samhouts added this to the 5.0.0 milestone Feb 12, 2021
@dependabot dependabot bot mentioned this pull request Mar 18, 2021
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hartez hartez hartez approved these changes

@PureWeen PureWeen PureWeen approved these changes

Assignees
No one assigned
Labels
a/a11y 🔍 a/backbutton i/high Completely doesn't work, crashes, or is unusably slow, has no obvious workaround; occurs less often m/high impact ⬛ p/Android t/bug 🐛
Projects
Accessibility
  
Done
5.0.0 SR 3
Done
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

A11y Android: The backbutton is pronounced "Button Unlabeled" when titles are set
4 participants
@rachelkang @hartez @PureWeen @samhouts