Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[iOS] Fixed date formatter issue with different timezone #13634

Merged
merged 1 commit into from
Feb 5, 2021
Merged

Conversation

jsuarezruiz
Copy link
Contributor

Description of Change

Fixed date formatter issue with different timezone on iOS. From this changes: 938700b#diff-e232660a1722e87a9febc4d293b145e11c6b707d432ae3f637d208e92d70a27d
We use a NSDateFormatter. Since we didn’t specify otherwise, the date formatter uses the system time zone, which is set to the location.
The fix is specify a time zone with a fixed temporal offset instead of a location.

Issues Resolved

API Changes

None

Platforms Affected

  • iOS

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

  1. Set the system datetime to 01/07/21 19:01h and timezone GMT+5.
  2. Launch Core Gallery.
  3. Look at the DatePicker, the date must be 01/07/21.

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@jsuarezruiz jsuarezruiz added t/bug 🐛 p/iOS 🍎 blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. a/datepicker labels Feb 3, 2021
@PureWeen PureWeen added this to To Fix in 5.0.0 SR 3 via automation Feb 4, 2021
@PureWeen PureWeen moved this from To Fix to PR Needs Review in 5.0.0 SR 3 Feb 4, 2021
@rmarinho rmarinho merged commit bca6f23 into 5.0.0 Feb 5, 2021
5.0.0 SR 3 automation moved this from PR Needs Review to Done Feb 5, 2021
@rmarinho rmarinho deleted the fix-13366 branch February 5, 2021 12:01
@samhouts samhouts added this to the 5.0.0 milestone Feb 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a/datepicker blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. i/regression p/iOS 🍎 t/bug 🐛
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Xamarin.Forms DatePicker shows incorrect date
6 participants