-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Fix material colors to match previous version better #13666
Conversation
@PureWeen Should we mark this PR with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the Entry is disabled in iOS, the bottom line is dashed, is an expected behavior?
@jsuarezruiz looking at 4.8 that hasn't changed so we can fix that with a different PR if we need to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the underline differences @jsuarezruiz noticed, lgtm!
// an issue with setting background color and having an image set | ||
if (Enabled && Element.ImageSource != null) | ||
{ | ||
Enabled = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Redth or @jsuarezruiz if you have any better thoughts or tricks to address this issue.
Description of Change
Issues Resolved
Platforms Affected
Behavioral/Visual Changes
Testing Procedure
PR Checklist