This repository has been archived by the owner on May 1, 2024. It is now read-only.
Prevent overeager cache invalidation when the CollectionView height changes by very small amounts #13738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hanges by very small amounts Fixes #13719
Redth
approved these changes
Feb 12, 2021
PureWeen
approved these changes
Feb 12, 2021
samhouts
added
5.0.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Under the right layout circumstances, the UICollectionView's size can repeatedly change by very, very small amounts (height differences less than 0.0001). The layout cell sizes cache was blindly invalidating even for very small changes, which caused layout jumps and incorrect scrollbar positions.
These changes prevent cache invalidation in those scenarios.
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
Testing Procedure
Grab the repro project from #13231 and update it to this PR; the CollectionView should scroll smoothly and should scroll all the way to the bottom of the last item. If the last item will no scroll fully into view, this PR is failing.
PR Checklist