This repository has been archived by the owner on May 1, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[iOS] Fix incorrect refresh indicador position using RefreshView with CollectionView Header #13773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
why is this not merged yet? |
Looking forward to seeing this in the next release of Xamarin Forms !!! |
please merge it asap |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
rachelkang
approved these changes
May 4, 2021
Where can I get the Xamarin.Forms version with this fix? On Nuget I can only find the 5.0.0.2012 where this issue is still present.. |
@jsuarezruiz do you know when we can expect the next service release to be available (with this fix)? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
a/collectionview
a/refreshview 🔄
blocker
Issue blocks next stable release. Prioritize fixing and reviewing this issue.
i/high
Completely doesn't work, crashes, or is unusably slow, has no obvious workaround; occurs less often
m/high impact ⬛
p/iOS 🍎
t/bug 🐛
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix incorrect refresh indicador position using RefreshView with CollectionView with Header on iOS.
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Before
After
Testing Procedure
Launch Core Gallery and navigate to the issue 8282. Pull to Refresh. If the loading indicator appears above the CollectionView header, the test has passed.
PR Checklist