Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[iOS] Fix incorrect refresh indicador position using RefreshView with CollectionView Header #13773

Merged
merged 5 commits into from
May 21, 2021

Conversation

jsuarezruiz
Copy link
Contributor

Description of Change

Fix incorrect refresh indicador position using RefreshView with CollectionView with Header on iOS.

Issues Resolved

API Changes

None

Platforms Affected

  • iOS

Behavioral/Visual Changes

None

Before/After Screenshots

Before

issue82822

After

fix8282

Testing Procedure

Launch Core Gallery and navigate to the issue 8282. Pull to Refresh. If the loading indicator appears above the CollectionView header, the test has passed.

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@jsuarezruiz jsuarezruiz added t/bug 🐛 p/iOS 🍎 i/high Completely doesn't work, crashes, or is unusably slow, has no obvious workaround; occurs less often blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. a/refreshview 🔄 labels Feb 16, 2021
@xleon
Copy link

xleon commented Apr 28, 2021

why is this not merged yet?

@thecuong064
Copy link

Looking forward to seeing this in the next release of Xamarin Forms !!!

@LuoyeAn
Copy link
Contributor

LuoyeAn commented Apr 30, 2021

please merge it asap

@rachelkang
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rmarinho
Copy link
Member

rmarinho commented May 4, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jsuarezruiz jsuarezruiz merged commit 1d0578c into 5.0.0 May 21, 2021
@jsuarezruiz jsuarezruiz deleted the fix-8282 branch May 21, 2021 07:26
@matteovelati
Copy link

Where can I get the Xamarin.Forms version with this fix? On Nuget I can only find the 5.0.0.2012 where this issue is still present..
Thanks

@argentini
Copy link

@jsuarezruiz do you know when we can expect the next service release to be available (with this fix)?

@rdeveen
Copy link

rdeveen commented Sep 2, 2021

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a/collectionview a/refreshview 🔄 blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. i/high Completely doesn't work, crashes, or is unusably slow, has no obvious workaround; occurs less often m/high impact ⬛ p/iOS 🍎 t/bug 🐛
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [iOS] RefreshView draws behind CollectionView Header
10 participants