Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[iOS] Fix shell search handler background color for iOS 13 or newer #13804

Merged
merged 1 commit into from
Nov 16, 2021
Merged

[iOS] Fix shell search handler background color for iOS 13 or newer #13804

merged 1 commit into from
Nov 16, 2021

Conversation

dennisstromberg
Copy link
Contributor

Description of Change

Change property to set background color in iOS13 or newer.

Issues Resolved

Platforms Affected

  • iOS

Behavioral/Visual Changes

Search handler will show the right background color.

Before/After Screenshots

Before:
before

After:
after

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@dnfadmin
Copy link

dnfadmin commented Feb 19, 2021

CLA assistant check
All CLA requirements met.

@PureWeen
Copy link
Contributor

PureWeen commented Feb 26, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jfversluis
Copy link
Member

Sorry it took a while @dennisstromberg but this is great, thank you so much for your PR!

@jfversluis jfversluis merged commit a7b30d8 into xamarin:5.0.0 Nov 16, 2021
@jfversluis
Copy link
Member

Look forward to the next release notes where you will get an honorable mention as a new contributor! Thanks again @dennisstromberg !

@jsauve
Copy link

jsauve commented Nov 29, 2021

I'm very much looking forward to this fix. What version of Xamarin Forms will it be included in? I'd implement it myself today in a custom renderer, but it's all contained within a private method, and uses a bunch of internal extension methods.

@jfversluis
Copy link
Member

Great @jsauve ! It should be in the upcoming Service Release which is planned for around December 15th. You can already try our nightly (see instructions on the README) which should have all the fixes that will lead up to the new service release. That way you can test if it works as intended. Please be sure to let me know :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
7 participants