This repository has been archived by the owner on May 1, 2024. It is now read-only.
Fixed the memory leak in the collectionview and gallery #14076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in some examples.
|
I tried to reach out to different community members get some confirmation on this issue and a review since it's my first PR here. Since everybody seems to be busy with Maui ;-) I just sent this PR to the 5.0.0 branch so it will not be forgotten. |
This was referenced Apr 6, 2021
jsuarezruiz
added
a/collectionview
a/performance
i/high
jsuarezruiz
added this to Issues in Progress
in 5.0.0 SR6 (Planning) - Target Date Oct. 13th
via automation
jsuarezruiz
approved these changes
Sep 16, 2021
5.0.0 SR6 (Planning) - Target Date Oct. 13th
automation
moved this from Issues in Progress
to Done
Sep 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Event handlers on the TemplatedCell are not being removed which results in the control to be left in memory which keeps the page where it is loaded also to stay behind in memory.
I added an unbind method on the TemplatedCell and unbind the event handlers in the ItemsViewController.
Also the TemplatedItemsList had a collectionchanged event which was not removed so I removed that as well.
If there is a better way to achieve this, please let me know and I will fix it in a better way.
Xamarin.Forms.Core/TemplatedItemsList.cs
Xamarin.Forms.Platform.iOS/CollectionView/ItemsViewController.cs
Xamarin.Forms.Platform.iOS/CollectionView/TemplatedCell.cs
All the other files are eventhandler fixes in the Gallery code.
Issues Resolved
API Changes
Added: Unbind() on TemplatedCell.cs to remove events
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
Testing Procedure
Go to the templated collectionview pages in the gallery and go back. Repeat couple of times and see page count increasing in the Xamarin Profiler.
PR Checklist