This repository has been archived by the owner on May 1, 2024. It is now read-only.
Route Navigation.(Push/Pop)Modal through Shell Navigation Manager #14080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
.... |
|
@shane Could you rebase to fix the conflicts?. Thanks!. |
|
@jsuarezruiz I kicked off the UI Tests I'd like those to run again with the previous shell PRs that got merged |
|
The failing UITests seem unrelated. |
|
I have a question on this fix. It seems thant since that, when you push a value by MessagingCenter on the the screen you ask NavigateTo the message was send before OnAppearing with the subscribe could run. So the message is not received. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
When the user called "Navigation.(Push/Pop)ModalAsync" those were operating outside the scope of Shell so it would confuse the ShellNavigationManager when trying to process cancellation tokens. This makes it so the Navigation calls to push/pop modal will correctly call Navigating/Navigated and also allow users to cancel those operations as well
Issues Resolved
Platforms Affected
Testing Procedure
PR Checklist