Fix up Android Accessibility behind a flag #14089

PureWeen · 2021-03-31T23:23:24Z

Description of Change

added Xamarin.AndroidX.Navigation.UI so I can use the resource id for reading the back button as "Navigate up"
added AccessibilityDelegateAutomationId so that if you set an AutomationId and the HelpText it'll read back the HelpText instead of the AutomationID
When setting AutomationId on controls that aren't implicitly accessible we need to turn "ImportantForAccessibility" off so that TalkBack doesn't start reading it
Disable extracting the defaults for hint and CD
Remove the "Touch" settings on the PlatformRenderer
Remove Clickable on the PageRenderer
Fix Shell so that it doesn't read out the ViewPager if the page has no top tabs

API Changes

Added:

Accessibility_Experimental Flag so that you can toggle these changes on and off.

Platforms Affected

Android

Testing Procedure

Turn this flag on and then click around in Control Gallery on the various TalkBack scenarios for Android. You'll see a flag you can uncomment inside FormsAppCompatActivity. The AutomationId page is a pretty good one to test. Before the flag it reads the AutomationId but then after the flag it continues to read the text

PR Checklist

Targets the correct branch
Tests are passing (or failures are unrelated)

PureWeen · 2021-03-31T23:24:22Z

Xamarin.Forms.Platform.Android/FastRenderers/AutomationPropertiesProvider.cs

+			if (!String.IsNullOrWhiteSpace(ConcatenateNameAndHelpText(element)))
+				return false;
+
+			if (element is Layout ||


This set of controls isn't going to change

This is a bug that's very specific to XF 5 and won't surface in MAUI as we won't be using ContentDescription

PureWeen · 2021-03-31T23:26:13Z

Xamarin.Forms.Platform.Android/AccessibilityDelegateAutomationId.cs

+
+namespace Xamarin.Forms.Platform.Android
+{
+	class AccessibilityDelegateAutomationId : AAccessibilityDelegate


This is very similar to what @ryl created here

https://github.com/xamarin/Xamarin.Forms/pull/5237/files#diff-d62639210acd753c36ed2128b141cb10e5bc1b4f5f1d1d95593823572f0c08f3R1

rachelkang · 2021-04-12T18:33:37Z

Xamarin.Forms.Platform.Android/FastRenderers/AutomationPropertiesProvider.cs

@@ -30,52 +32,102 @@ internal static void GetDrawerAccessibilityResources(global::Android.Content.Con
 			resourceIdClose = context.Resources.GetIdentifier($"{automationIdParent}{s_defaultDrawerIdCloseSuffix}", "string", context.ApplicationInfo.PackageName);
 		}

+		static bool ShoudISetImportantForAccessibilityToNoIfAutomationIdIsSet(AView control, Element element)


Can we come up with a better, shorter name for this bool?

If the name is clear about what it's doing then no
If it's not clear then yes

It's better to be verbose and clear with methods names then short/clever/and confusing

rachelkang · 2021-04-12T18:36:10Z

Xamarin.Forms.Platform.Android/Renderers/ShellToolbarTracker.cs

+				if(CanNavigateBack)
+					toolbar.SetNavigationContentDescription(Resource.String.nav_app_bar_navigate_up_description);
+				else
+					toolbar.SetNavigationContentDescription(R.String.Ok);


should we still set it to ok? maybe we should just not set it to anything? then maybe it'll read like the native default that just reads as "unlabeled button"

Is there an option for a "null" or "default"? Because if I read the code it's not really OK....

Because if I read the code it's not really OK....

What do you mean "read the code?"

If you set it to null then it just reads out as "Button Unlabeled"

PureWeen · 2021-05-28T15:05:21Z

/azp run

PureWeen · 2021-05-28T15:05:30Z

/azp run

azure-pipelines · 2021-05-28T15:05:43Z

Azure Pipelines successfully started running 1 pipeline(s).

PureWeen requested a review from rachelkang March 31, 2021 23:23

PureWeen requested a review from StephaneDelcroix as a code owner March 31, 2021 23:23

PureWeen commented Mar 31, 2021

View reviewed changes

rachelkang approved these changes Apr 12, 2021

View reviewed changes

PureWeen changed the title ~~[WiP] Fix up Android Accessibility behind a flag~~ Fix up Android Accessibility behind a flag Apr 13, 2021

rachelkang mentioned this pull request Apr 21, 2021

[Bug] accessibility issues for screen reader users #14104

Open

PureWeen mentioned this pull request May 7, 2021

Base implementations for SemanticEffect and SemanticOrderView xamarin/XamarinCommunityToolkit#1240

Merged

6 tasks

PureWeen added this to the 5.0.0 milestone May 7, 2021

PureWeen added this to Issue In progress in 5.0.0 SR 4 (Planning) via automation May 7, 2021

PureWeen moved this from Issue In progress to PR Needs Review in 5.0.0 SR 4 (Planning) May 7, 2021

PureWeen closed this May 28, 2021

5.0.0 SR 4 (Planning) automation moved this from PR Needs Review to Done May 28, 2021

PureWeen reopened this May 28, 2021

5.0.0 SR 4 (Planning) automation moved this from Done to Issue In progress May 28, 2021

PureWeen added 8 commits June 8, 2021 15:47

Fix up Android Accessibility behind a flag

c2e99c0

- automation id

8aef4da

- set back button to standard "Navigate Up"

18937af

- view compat

dce4f1a

- add flag check

5575507

- fix assigning of delegate

2a38298

- add flag to forms appcompat activity

bfb4d86

- fix nav drawer

42f0595

PureWeen force-pushed the accessibilityFlags branch from 719adf5 to 42f0595 Compare June 8, 2021 20:47

rmarinho merged commit 5209ec5 into 5.0.0 Jun 9, 2021

rmarinho deleted the accessibilityFlags branch June 9, 2021 08:25

5.0.0 SR 4 (Planning) automation moved this from Issue In progress to Done Jun 9, 2021

PureWeen mentioned this pull request Jul 27, 2021

Merge fixes from XF 5.0.0 SR4 into MAUI dotnet/maui#1830

Merged

rachelkang mentioned this pull request Nov 5, 2021

[Android] Using AutomationId prevents TalkBack screenreader accessibility #1529

Closed

rachelkang mentioned this pull request Nov 17, 2021

[Android] ModalPage has Clickable set to true on PageRenderer #14242

Closed

jfversluis mentioned this pull request Jan 14, 2022

Verify we can take out the accessibility feature flag and turn it on by default #15054

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix up Android Accessibility behind a flag #14089

Fix up Android Accessibility behind a flag #14089

PureWeen commented Mar 31, 2021 •

edited

Loading

PureWeen Mar 31, 2021

PureWeen Mar 31, 2021

rachelkang Apr 12, 2021

PureWeen Apr 13, 2021

rachelkang Apr 12, 2021

DDSoftDennie Apr 12, 2021

PureWeen Apr 13, 2021 •

edited

Loading

PureWeen commented May 28, 2021

PureWeen commented May 28, 2021

azure-pipelines bot commented May 28, 2021

Fix up Android Accessibility behind a flag #14089

Fix up Android Accessibility behind a flag #14089

Conversation

PureWeen commented Mar 31, 2021 • edited Loading

Description of Change

API Changes

Platforms Affected

Testing Procedure

PR Checklist

PureWeen Mar 31, 2021

Choose a reason for hiding this comment

PureWeen Mar 31, 2021

Choose a reason for hiding this comment

rachelkang Apr 12, 2021

Choose a reason for hiding this comment

PureWeen Apr 13, 2021

Choose a reason for hiding this comment

rachelkang Apr 12, 2021

Choose a reason for hiding this comment

DDSoftDennie Apr 12, 2021

Choose a reason for hiding this comment

PureWeen Apr 13, 2021 • edited Loading

Choose a reason for hiding this comment

PureWeen commented May 28, 2021

PureWeen commented May 28, 2021

azure-pipelines bot commented May 28, 2021

PureWeen commented Mar 31, 2021 •

edited

Loading

PureWeen Apr 13, 2021 •

edited

Loading