Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

CSS: Support omitting semicolon from last property #14306

Merged
merged 1 commit into from
Jan 12, 2022

Conversation

chucker
Copy link
Contributor

@chucker chucker commented May 29, 2021

Description of Change

[ main may be the more appropriate branch, but it's a relatively small change. ]

The current CSS parser doesn't support declarations like label {font-size: 18; background-color: red} where the final semicolon is omitted. These are, however, valid CSS.

This fixes that behavior and introduces a few unit tests to check for such edge cases.

Issues Resolved

Testing Procedure

Run all tests in the Xamarin.Forms.Core.UnitTests.StyleSheets and Xamarin.Forms.StyleSheets.UnitTests namespaces.

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@jfversluis jfversluis added this to Issues in Progress in 5.0.0 SR9 (Planning) - Target Date Jan. 19th via automation Dec 24, 2021
@jfversluis jfversluis moved this from Issues in Progress to PR Build/Test Failures/Review Feedback in 5.0.0 SR9 (Planning) - Target Date Jan. 19th Dec 24, 2021
@jfversluis jfversluis moved this from PR Build/Test Failures/Review Feedback to PR Needs Review in 5.0.0 SR9 (Planning) - Target Date Jan. 19th Dec 24, 2021
@jfversluis
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jfversluis
Copy link
Member

Hey @chucker thanks so much for your time and effort here and special thanks for your patience. Small change but I think some might be happy with it!

@jfversluis jfversluis merged commit 763bf92 into xamarin:5.0.0 Jan 12, 2022
5.0.0 SR9 (Planning) - Target Date Jan. 19th automation moved this from PR Needs Review to Done Jan 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

[Enhancement] Support minified stylesheets
3 participants