This repository has been archived by the owner on May 1, 2024. It is now read-only.
CSS: Support omitting semicolon from last property #14306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
approved these changes
Sep 21, 2021
jfversluis
added this to Issues in Progress
in 5.0.0 SR9 (Planning) - Target Date Jan. 19th
via automation
jfversluis
moved this from Issues in Progress
to PR Build/Test Failures/Review Feedback
in 5.0.0 SR9 (Planning) - Target Date Jan. 19th
jfversluis
moved this from PR Build/Test Failures/Review Feedback
to PR Needs Review
in 5.0.0 SR9 (Planning) - Target Date Jan. 19th
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hey @chucker thanks so much for your time and effort here and special thanks for your patience. Small change but I think some might be happy with it! |
jfversluis
approved these changes
Jan 12, 2022
5.0.0 SR9 (Planning) - Target Date Jan. 19th
automation
moved this from PR Needs Review
to Done
Jan 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
[
mainmay be the more appropriate branch, but it's a relatively small change. ]The current CSS parser doesn't support declarations like
label {font-size: 18; background-color: red}where the final semicolon is omitted. These are, however, valid CSS.This fixes that behavior and introduces a few unit tests to check for such edge cases.
Issues Resolved
Testing Procedure
Run all tests in the
Xamarin.Forms.Core.UnitTests.StyleSheetsandXamarin.Forms.StyleSheets.UnitTestsnamespaces.PR Checklist