Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[iOS] CollectionView iOS inner crash while adding items to group, items aren't displayed #13268 #14341

Merged
merged 1 commit into from
Oct 11, 2021

Conversation

bondarenkod
Copy link
Contributor

Description of Change

See issue description in the related issue.
Also, I'd like to mention #13268 (comment) and #13268 (comment) to save yours time.

Issues Resolved

API Changes

None

Platforms Affected

  • iOS

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

Run the test #13268, you should see a list with items, app didn't crash

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@net-foundation-cla
Copy link

net-foundation-cla bot commented Jun 9, 2021

CLA assistant check
All CLA requirements met.

@bondarenkod bondarenkod marked this pull request as ready for review June 9, 2021 22:12
@bondarenkod
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 14341 in repo xamarin/Xamarin.Forms

@bondarenkod bondarenkod changed the title trying to fix the #13268 [iOS] CollectionView iOS inner crash while adding items to group, items aren't displayed #13268 Jun 10, 2021
@jsuarezruiz jsuarezruiz requested a review from hartez June 10, 2021 10:19
@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@jsuarezruiz jsuarezruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bondarenkod Thanks so much for your PR. I have tried it and works:

Captura de pantalla 2021-09-16 a las 16 20 45

But is also working without the changes. Could you try your sample in 5.0.0 without the changes to confirm it?

@jfversluis jfversluis moved this from Issues in Progress to PR Needs Review in 5.0.0 SR6 (Planning) - Target Date Oct. 13th Oct 5, 2021
@bondarenkod
Copy link
Contributor Author

bondarenkod commented Oct 5, 2021

Hei! @jsuarezruiz
Thank you for your attention!
I'm deeply sorry for a huge delay, I've just recently noticed changes here.

I've tested the latest branch of XF5.0.0, moved my 13268.cs repro file there.
I cannot confirm that the issue is gone.
Tested on iOS15 emu, using the xamarin.ios-15.0.0.6 on the Mac side and VS 16.10.3 on the Windows side.
devenv_05_10_2021__16_57_24__22970ad9-057a-4773-a6af-d2f9141dab5d

@bondarenkod
Copy link
Contributor Author

bondarenkod commented Oct 5, 2021

I hope I did the merge for the conflict right. That was easier than from desktop.

@jfversluis
Copy link
Member

jfversluis commented Oct 11, 2021

/azp run

@azure-pipelines

This comment has been minimized.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jfversluis
Copy link
Member

Amazing job @bondarenkod thank you so much for this! You can now call yourself an official Xamarin.Forms contributor!

@jfversluis jfversluis merged commit f0bd72d into xamarin:5.0.0 Oct 11, 2021
5.0.0 SR6 (Planning) - Target Date Oct. 13th automation moved this from PR Needs Review to Done Oct 11, 2021
@lndalmd
Copy link

lndalmd commented Mar 30, 2022

Hello guys,
Was this fix published in any release?

I've tried on the 5.0.0.2401 and the issue is still there.

@bondarenkod
Copy link
Contributor Author

bondarenkod commented Mar 30, 2022

Hello guys, Was this fix published in any release?
I've tried on the 5.0.0.2401 and the issue is still there.

Yes.
That's another one?
Could you check XF sources and run locally demo for the 13268 from sources?
https://github.com/xamarin/Xamarin.Forms/blob/5.0.0/Xamarin.Forms.Platform.iOS/CollectionView/ObservableGroupedSource.cs#L175

@MSicc
Copy link

MSicc commented Apr 25, 2022

Hello guys, Was this fix published in any release?

I've tried on the 5.0.0.2401 and the issue is still there.

Sadly, it is :-(

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

[Bug] [iOS] CollectionView iOS inner crash while adding items to group, items aren't displayed
5 participants