This repository has been archived by the owner on May 1, 2024. It is now read-only.
Fix iOS so if you remove more than one page it's able to remove them successfully #14383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
commented
Jun 30, 2021
| // ViewControllers = ViewControllers.Remove(vc1) | ||
| // ViewControllers = ViewControllers.Remove(vc2) | ||
| // You've now added vc1 back because the second call to ViewControllers will still return a ViewControllers list with vc1 in it | ||
| UIViewController[] _pendingViewControllers; |
There was a problem hiding this comment.
This is the file with most of the changes relevant to the PR
rmarinho
reviewed
Jul 2, 2021
rmarinho
reviewed
Jul 2, 2021
rmarinho
reviewed
Jul 2, 2021
rmarinho
approved these changes
Jul 5, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
When you set the ViewControllers property on UINavigationController it doesn't take right away. If you retrieve the ViewControllers it will still contain the ViewController you just removed. This means if you do something like
So when processing a navigation with removes/inserts we now save local copy of pending changes.
Issues Resolved
Platforms Affected
Testing Procedure
PR Checklist