This repository has been archived by the owner on May 1, 2024. It is now read-only.
[iOS, UWP] Background Brush issues #14614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you update the PR description and title? this does a bit more than adding a sample, it adds an |
jsuarezruiz
changed the title
jsuarezruiz
added this to Issues in Progress
in 5.0.0 SR6 (Planning) - Target Date Oct. 13th
via automation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@StephaneDelcroix You are right, updated the description. |
jfversluis
moved this from Issues in Progress
to PR Needs Review
in 5.0.0 SR6 (Planning) - Target Date Oct. 13th
jfversluis
added this to PR Build/Test Failures
in 5.0.0 SR7 (Planning) - Target Date Nov. 10th
jfversluis
removed this from PR Needs Review
in 5.0.0 SR6 (Planning) - Target Date Oct. 13th
jfversluis
moved this from PR Build/Test Failures
to PR Needs Review
in 5.0.0 SR7 (Planning) - Target Date Nov. 10th
jfversluis
approved these changes
Oct 19, 2021
5.0.0 SR7 (Planning) - Target Date Nov. 10th
automation
moved this from PR Needs Review
to Done
Oct 19, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Add an implicit conversion from Color to SolidColorBrush to avoid issues where the binding value use a wrong type.
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
PR Checklist