Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[iOS] Fix CollectionView issue selection multiple items #14621

Merged
merged 3 commits into from
Oct 11, 2021
Merged

Conversation

jsuarezruiz
Copy link
Contributor

Description of Change

Fix CollectionView issue with selection of multiple items on iOS.

Issues Resolved

API Changes

None

Platforms Affected

  • iOS

Behavioral/Visual Changes

None

Before/After Screenshots

fix13592

Testing Procedure

Launch Core Gallery and navigate to the issue 13592. If both CollectionViews have items selected, the test has passed.

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@jsuarezruiz
Copy link
Contributor Author

cc @Tommigun1980

@Tommigun1980
Copy link

cc @Tommigun1980

Thank you!

Fwiw a very similar problem happens with SelectionMode Single, does this fix that also? The repro project can be edited to use Single instead and it should show that error also.

Thank you again for fixing this!

@jfversluis
Copy link
Member

jfversluis commented Sep 21, 2021

Fwiw a very similar problem happens with SelectionMode Single, does this fix that also? The repro project can be edited to use Single instead and it should show that error also.

It would greatly help us if you could test that. Since you are the one spotting this bug, you can judge best if all scenarios are fixed :)

See I read it wrong now, sorry about that. Is there also an issue for the single selection mode? It seems to be working fine, at least with the changes in this code :)

@jfversluis jfversluis moved this from Issues in Progress to PR Needs Review in 5.0.0 SR6 (Planning) - Target Date Oct. 13th Sep 21, 2021
@jfversluis jfversluis merged commit 3703741 into 5.0.0 Oct 11, 2021
5.0.0 SR6 (Planning) - Target Date Oct. 13th automation moved this from PR Needs Review to Done Oct 11, 2021
@jfversluis jfversluis deleted the fix-13592 branch October 11, 2021 13:19
@tnt-lrt
Copy link

tnt-lrt commented Mar 25, 2022

Hi guys,

the behavior of the class ItemComparer, introduced in this fix is non-determenistic. For example when just valueA is implementing IComparable and valueB is not it might throw an exception. If you swap both values it will return false.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

[Bug] CollectionView initial selection is broken
4 participants