-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[iOS] Fix Shell NavigationBar and TabBar color issues #14649
Conversation
Got some build errors here @jsuarezruiz |
@rmarinho Could we take a look to the build together? |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Shell seems fine. Please push asap! |
Xamarin.Forms.Platform.iOS/Renderers/ShellNavBarAppearanceTracker.cs
Outdated
Show resolved
Hide resolved
Added changes to fix also: #14679 |
Xamarin.Forms.Platform.iOS/Renderers/SafeShellTabBarAppearanceTracker.cs
Outdated
Show resolved
Hide resolved
var navigationBarAppearance = new UINavigationBarAppearance(); | ||
navigationBarAppearance.ConfigureWithOpaqueBackground(); | ||
|
||
navBar.Translucent = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In line with the one for tab bar... Not sure about this one?
I believe that this issue is partially fixed. The tab coloring updates on iPhone devices, but not on iPads. In this example, the iPhone has a green foreground text color, but the iPad retains the standard blue color. This was tested against Xamarin.Forms 5.0.0.2196. Sample Shell implementation used for testing. This should match up pretty closely to the unit tests.
|
@michaelstonis Yep already fixed in #14775 |
Awesome. I had missed this issue. Thanks! |
Description of Change
Fix Shell NavigationBar and TabBar color issues on iOS 15.
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
Testing Procedure
PR Checklist