Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[iOS] CollectionView not applying "Selected" VisualState to pre-selected items #14672

Merged
merged 3 commits into from
Nov 26, 2021

Conversation

jsuarezruiz
Copy link
Contributor

Description of Change

Fix issue where the CollectionView not applying "Selected" VisualState to pre-selected items (initial selection).

Issues Resolved

API Changes

None

Platforms Affected

  • iOS

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

Launch Core Gallery and navigate to the issue 14513. If the selected item have a Red background, the test has passed.

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@jsuarezruiz jsuarezruiz added t/bug 🐛 p/iOS 🍎 i/high Completely doesn't work, crashes, or is unusably slow, has no obvious workaround; occurs less often a/collectionview labels Sep 29, 2021
@jsuarezruiz jsuarezruiz added this to Issues in Progress in 5.0.0 SR6 (Planning) - Target Date Oct. 13th via automation Sep 29, 2021
@jfversluis jfversluis moved this from Issues in Progress to PR Needs Review in 5.0.0 SR6 (Planning) - Target Date Oct. 13th Oct 2, 2021
Copy link
Member

@jfversluis jfversluis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for a single selection, but doesn't work for initial multi-selection. E.g. 13592 that I merged just before this only has the first one with the proper visual

image

Weird thing is that selected does get set to true for the other cells, but it doesn't seem to renderer as such.

@jfversluis jfversluis moved this from PR Needs Review to PR Build/Test Failures/Review Feedback in 5.0.0 SR7 (Planning) - Target Date Nov. 10th Oct 19, 2021
@jfversluis jfversluis added this to Issues in Progress in 5.0.0 SR8 (Planning) - Target Date Dec. 15th via automation Nov 17, 2021
@jfversluis jfversluis removed this from PR Build/Test Failures/Review Feedback in 5.0.0 SR7 (Planning) - Target Date Nov. 10th Nov 17, 2021
@jfversluis jfversluis moved this from Issues in Progress to PR Build/Test Failures/Review Feedback in 5.0.0 SR8 (Planning) - Target Date Dec. 15th Nov 17, 2021
@danielcabral-code
Copy link

hey @jfversluis how would I go about implementing this fix? thanks!

@jfversluis
Copy link
Member

Hey @danielcabral-code glad you found your way here, thank you!

Would you be able to grab the NuGet as described here and let us know if this fixes this issue? That will greatly speed up the review process. Make sure in this case you get the exact version of 5.0.0.7746

Besides verifying if this particular issue is fixed also be sure to check other scenarios in the same area to make sure that this fix doesn't accidentally has side-effects 🙂

Thanks!

@jfversluis
Copy link
Member

I did some additional testing and actually it seems to look good for me. Please still test whatever you can @danielcabral-code. In 24 hours this should now also be part of the nightly feed (find instructions in the README on the front page), so you could test that as well. Please open an issue if you still find anything.

@jfversluis jfversluis merged commit 8fcf863 into 5.0.0 Nov 26, 2021
5.0.0 SR8 (Planning) - Target Date Dec. 15th automation moved this from PR Build/Test Failures/Review Feedback to Done Nov 26, 2021
@jfversluis jfversluis deleted the fix-14513 branch November 26, 2021 10:44
@danielcabral-code
Copy link

Hey @jfversluis I finally got around to testing the fix. It worked a charm! Thanks!

@jfversluis
Copy link
Member

Hooray, perfect, thanks for confirming @danielcabral-code !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a/collectionview i/high Completely doesn't work, crashes, or is unusably slow, has no obvious workaround; occurs less often p/iOS 🍎 t/bug 🐛
Projects
No open projects
3 participants