This repository has been archived by the owner on May 1, 2024. It is now read-only.
Block keyboard for iOS 15 time picker #14690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This changes blocks showing the keyboard input when you tap the time picker on an iPad. While ideally we should allow the user to input a time with a numeric keyboard, this blocks the keyboard as a whole as an intermediate solution. Effectively this reverts the functionality to what it was before iOS 15 so nothing was lost nor added.
Note: only happens on iOS 15 and an iPad
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
Right now when you tap on a time in the TimePicker you will get a full keyboard in a too small popup making it look weird. On top of that, it's not even functional.
With this change when you tap a time in the TimePicker, nothing happens as it was before.
Before/After Screenshots
Before
After
Testing Procedure
Go to the TimePicker in the gallery, pick any property, open the TimePicker wheels and tap on the selected time. Nothing should happen. When testing on the Simulator, make sure the soft-keyboard is on (CMD + Shift + K)
PR Checklist