Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Android] Fix issue with Shape not resizing correctly (rotate screen) #14702

Merged
merged 4 commits into from
Oct 20, 2021

Conversation

jsuarezruiz
Copy link
Contributor

Description of Change

Fix issue with Shape not resizing correctly (rotate screen).

Issues Resolved

API Changes

None

Platforms Affected

  • Android

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

Launch Core Gallery and navigate to the issue 14697. Rotate the Device or Emulator If the Shape size adapts (Aspect = Uniform), the test has passed.

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@MitchBomcanhao
Copy link

I was hoping to try this change, but the build went boom, so no package to test :(

@jsuarezruiz
Copy link
Contributor Author

@MitchBomcanhao Now the build is passing, could you try the package?

@MitchBomcanhao
Copy link

@jsuarezruiz thanks, I've been looking into it this morning. I've added more information on bug #14697 - essentially:

  • resizing seems to work
  • replacing path data does not

You can find more detail and screenshots in the bug page.

@jfversluis
Copy link
Member

@jsuarezruiz @MitchBomcanhao if I understand correctly this PR still needs some work?

@MitchBomcanhao
Copy link

MitchBomcanhao commented Oct 19, 2021

@jsuarezruiz @jfversluis well, the first change you've done is already very positive 👍(shame it didn't make the cut to SR6), but the path should also rescale itself when the path data value is changed.
With your PR as is I can write a very basic workaround to have it resize the container (by a very small fraction) whenever the path data changes, thus triggering the redraw, but it should just work as it used to before the regression. Change the path data? Should rescale accordingly.

Thanks

@jfversluis
Copy link
Member

So, merging this would help you, but the 100% fix needs some additional work. Does it make sense to merge this as is, open a new issue with the remainder and see if we can get to that? Then at least you have some progress here.

@MitchBomcanhao
Copy link

yes, that would be ok. would you want me to log the new bug entry?

@MitchBomcanhao
Copy link

FYI created bug #14765

@jfversluis
Copy link
Member

Great, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug][Android] Shape no longer redrawing itself when the container changes size (sr4 and sr5)
3 participants