[Android] Set TextColor to search icon in SearchBar

[jsuarezruiz]

Description of Change

Set TextColor to search icon in SearchBar. In this way, is easy to manage the desire color. Until now this color depended on AndroidProject/Resources/values/styles.xml and the styles used. Without setting a TextColor this will be the fallback behavior.

@jfversluis What is your opinion in this case?

Issues Resolved

• fixes [Bug] Search icon color wrong with 4.4 #9266

API Changes

None

Platforms Affected

• Android

Behavioral/Visual Changes

None

Before/After Screenshots

Testing Procedure

Launch Core Gallery and navigate to the issue 9266. If the Search icon color is Yellow, the test has passed.

PR Checklist

• Targets the correct branch
• Tests are passing (or failures are unrelated)

[jfversluis]

Let's not do this for Forms anymore. While this doesn't introduce any new APIs, it still is a breaking change from a behavioral perspective. People who might've set the font color today expect the icon not to change. If we would merge this then suddenly their icons start to change without a way to revert that.

One way or the other we are going to have to introduce a breaking change for this which is something we would want to avoid. Sorry :(

Looking at the original issue we might already set the icon to the text color before Xamarin 4.4. I will need to dive in a bit deeper in that case.

[jfversluis]

I think at this point it's safe to say this won't be happening for Xamarin.Forms anymore. Let's make it happen for .NET MAUI!