This repository has been archived by the owner on May 1, 2024. It is now read-only.
UWP TitleView Width not updated after push/pop Modal #14779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ain after a PushModal and PopModal call. TitleViewManager is unregistered at CommandBar unload from the page calling PushModal. After the page gets visible again by a PopModal the CommandBar is reloaded again but the TitleViewManager is not re-registered. This is a fix for that problem.
2 tasks
jfversluis
added this to Issues in Progress
in 5.0.0 SR7 (Planning) - Target Date Nov. 10th
via automation
jfversluis
moved this from Issues in Progress
to PR Needs Review
in 5.0.0 SR7 (Planning) - Target Date Nov. 10th
YZahringer
approved these changes
Oct 22, 2021
jsuarezruiz
approved these changes
Oct 25, 2021
5.0.0 SR7 (Planning) - Target Date Nov. 10th
automation
moved this from PR Needs Review
to Done
Oct 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Takeover from #10849]
TitleViewManager is unregistered at CommandBar unload from the page calling PushModal. After the page gets visible again by a PopModal
the CommandBar is reloaded again but the TitleViewManager is not re-registered.
This is a fix for that problem.
Description of Change
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
Testing Procedure
PR Checklist