Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Allow 1 modifier key to be added on macOS #14831

Merged
merged 1 commit into from
Nov 5, 2021
Merged

Allow 1 modifier key to be added on macOS #14831

merged 1 commit into from
Nov 5, 2021

Conversation

jfversluis
Copy link
Member

Description of Change

Because of a faulty if statement in the code it was not possible to add just 1 modifier key to trigger a menu item on macOS, this is now fixed.

Issues Resolved

API Changes

None

Platforms Affected

  • macOS

Behavioral/Visual Changes

Now 1 modifier key can be added to trigger a MenuItem instead of having to use multiple

Before/After Screenshots

Not applicable

Testing Procedure

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@jfversluis jfversluis merged commit 78d9f87 into 5.0.0 Nov 5, 2021
@jfversluis jfversluis deleted the fix-1749 branch November 5, 2021 12:33
@srkidd12
Copy link

srkidd12 commented Feb 6, 2022

Is Xamarin.Forms.Platform.MacOS no longer public or how do you access in on a mac?

@jfversluis
Copy link
Member Author

@srkidd12 not sure what you mean? Nothing has been changed in that area :)

@srkidd12
Copy link

srkidd12 commented Feb 7, 2022

The NuGet package is not on Nuget.org or searchable anymore. Do I need to manually build it?

@jfversluis
Copy link
Member Author

This change was merged so it should be included in the current Xamarin.Forms version

@jfversluis jfversluis added maui-validated Issue/PR has been validated to not be an issue in .NET MAUI/PR has been opened/merged in .NET MAUI and removed needs-maui-validation labels Mar 2, 2022
@rmarinho
Copy link
Member

Hehe :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maui-validated Issue/PR has been validated to not be an issue in .NET MAUI/PR has been opened/merged in .NET MAUI p/macOS t/bug 🐛
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Desktop support: can't set a single modifier on an accelerator (macOS)
4 participants